Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assembler: Unset white background #89343

Closed
wants to merge 1 commit into from
Closed

Assembler: Unset white background #89343

wants to merge 1 commit into from

Conversation

taipeicoder
Copy link
Contributor

@taipeicoder taipeicoder commented Apr 9, 2024 •
edited
Loading

Fixes #89324

Proposed Changes

This PR fixes the issue where the background colors from global styles are not applied in the block renderer in the Assembler. This is caused by https://github.com/WordPress/gutenberg/pull/59377/files, where the background is explicitly set to white.

Note that the issue only affects Safari.

Testing Instructions

  1. Using Safari, head to the Assembler.
  2. Select some patterns, then styles.
  3. Ensure that the background color from the global styles is applied correctly to the pattern in the large preview.
  4. Ensure that Chrome and Safari also works as before.

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • https://wpcalypso.wordpress.com/devdocs/docs/testing/index.md for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 9, 2024

Calypso Live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-4f431f73022b48f06805461aecbda9e91c084b33
Jetpack Cloud live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-4f431f73022b48f06805461aecbda9e91c084b33&env=jetpack
Automattic for Agencies live (direct link)
https://calypso.live?image=registry.a8c.com/calypso/app:commit-4f431f73022b48f06805461aecbda9e91c084b33&env=a8c-for-agencies

@taipeicoder taipeicoder marked this pull request as ready for review April 9, 2024 03:33
@taipeicoder taipeicoder requested a review from a team April 9, 2024 03:33
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 9, 2024
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~46 bytes added 📈 [gzipped])

name         parsed_size           gzip_size
patterns           +64 B  (+0.0%)      +24 B  (+0.0%)
import-flow        +64 B  (+0.0%)      +22 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@taipeicoder taipeicoder self-assigned this Apr 9, 2024
arthur791004
arthur791004 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@arthur791004 arthur791004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good to me!

Before After
image image

arthur791004
arthur791004 reviewed Apr 9, 2024
View reviewed changes
Copy link
Contributor

@arthur791004 arthur791004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh but it doesn't work on the preview of the pattern list

@taipeicoder
Copy link
Contributor Author

Oh but it doesn't work on the preview of the pattern list

@arthur791004 do you mean the pattern list in the sidebar? I don't remember the global styles being applied there before...
Screenshot 2024-04-09 at 12 37 16 PM

@arthur791004
Copy link
Contributor

It did work on other browsers, e.g.: Edge

image

@arthur791004
Copy link
Contributor

But I think we can move this forward and address it later 🙂

@taipeicoder
Copy link
Contributor Author

Seems that there's already a fix in WordPress/gutenberg#60106, which is available in @wordpress/block-editor 12.23.0. Currently, the version in Calypso is 12.22.0.

@tyxla do you know if/when the next wordpress/* packages dependency update is scheduled for? Or is it something we can request? Thanks in advance!

@taipeicoder
Copy link
Contributor Author

Closing this PR as I consider updating the wordpress packages is a more robust solution to this issue.

@taipeicoder taipeicoder closed this Apr 9, 2024
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 9, 2024
@taipeicoder taipeicoder mentioned this pull request Apr 9, 2024
Closed
@tyxla
Copy link
Member

tyxla commented Apr 15, 2024

@tyxla do you know if/when the next wordpress/* packages dependency update is scheduled for? Or is it something we can request? Thanks in advance!

For some reason, renovate never came up with it. I was away last week, but I'll be taking a look at it this week.

@tyxla
Copy link
Member

tyxla commented Apr 18, 2024

We've updated the @wordpress packages to the latest ones: #89640

@taipeicoder
Copy link
Contributor Author

We've updated the @wordpress packages to the latest ones: #89640

Nice! Thanks so much for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthur791004 arthur791004 arthur791004 approved these changes

Assignees

@taipeicoder taipeicoder

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Assembler color styles are not applied properly within Safari
4 participants
@taipeicoder @matticbot @arthur791004 @tyxla